Don't forget to remove debug code

srcodersrcoder
edited August 2017 in 1Password X (beta)

Hi guys,

Using the console in the browser a lot and I noticed you're console.log(ing) too.

There is this script content/s.js which creates a uuid and console.log('Content script loaded ${uuid}',window) on every page.
Just a reminder to remove this in the near future.


1Password Version: Not Provided
Extension Version: 0.8.4
OS Version: Not Provided
Sync Type: Not Provided

Comments

  • beyerbeyer

    Team Member

    Hey @srcoder,

    Sorry for the slight annoyance, I've gone ahead and removed this for now which you'll see in our next release. There's nothing sensitive in this log entry, but we aren't using it at the moment, so it doesn't need to be there.

    Thanks for bringing it up and have a great week. :)

    --
    Andrew Beyer (Ann Arbor, MI)
    Lifeline @ AgileBits

  • You too @beyer!

  • beyerbeyer

    Team Member

    Thanks! :) :+1:

  • pbzpbz
    edited August 2017

    Not sure if that counts as "sensitive information" but there is a local path of the development machine in your bundled background.js file:
    /Users/davidteare/.npm-global/lib/node_modules/webpack/node_modules/browserify-sign

    Comes from the module elliptic I guess.

  • beyerbeyer

    Team Member

    @pbz: Thanks for letting us know. <3

    My buddy Mitch has drastically changed our build process this week, and I'm not seeing this anymore. :+1:

    I'll double-check in the next release, but we should be good. :)

    --
    Andrew Beyer (Ann Arbor, MI)
    Lifeline @ AgileBits

  • Resolved in 0.8.5 :chuffed:

  • beyerbeyer

    Team Member

    Great, thanks for letting us know!

    --
    Andrew Beyer (Ann Arbor, MI)
    Lifeline @ AgileBits

Leave a Comment

BoldItalicStrikethroughOrdered listUnordered list
Emoji
Image
Align leftAlign centerAlign rightToggle HTML viewToggle full pageToggle lights
Drop image/file