Markdown code-block layout bug

Options
polarweasel
polarweasel
Community Member

Yes, this is a nitpick, but it's really annoying. :)

The Markdown layout engine is not adding a blank after code blocks. See the attached screenshots for details: source first, then display. There should be a blank line between "(ends here)" and "Heading 2".


1Password Version: 7.0.4
Extension Version: 4.7.1
OS Version: macOS 10.13.6 beta (17G47b)
Sync Type: Not Provided

Comments

  • Lars
    Lars
    1Password Alumni
    Options

    @polarweasel - well-spotted! I'm sorry for the inconvenience. And never mind about "nitpicking," making this work properly is hardly a non-priority. It's not as high-priority as security issues, but obviously we want this feature to work the way people expect. The problem is that we can't really adopt Markdown whole-hog, running Perl scripts within 1Password. We need to consider attack vectors that, say, a text editing app probably would not. We're looking to get this solved (along with a couple of other Markdown-related issues) in a future update to 1Password 7 for Mac, so stay tuned and keep an eye on release notes/updates.

  • polarweasel
    polarweasel
    Community Member
    Options

    Understood! Any user input should always be suspect, from a security perspective. Looking forward to the future update. :)

  • Ben
    Options

    :+1: :)

    Ben

  • polarweasel
    polarweasel
    Community Member
    Options

    Follow-up on this one from 1P 7.0.5 (and as of just now, 7.0.6)... The Markdown code block formatting is much improved, but a code block at the end of a note now gets its bottom outline cut off. No information is lost, but it looks weird. :)

  • rudy
    Options

    @polarweasel,

    Thanks for the feedback, we're continuing to improve the first line/last line behaviors with the types that add additional framing (code block/quote/pre-formatted).

    Rudy

  • polarweasel
    polarweasel
    Community Member
    Options

    @rudy thanks, and good luck! I know it's a can of worms. :)

  • rudy
    Options

    @polarweasel

    That it is. :+1: :)

This discussion has been closed.