Suggest passwords for frame domain

shreveshreve
edited March 2018 in 1Password X (beta)

I'm not sure if this is possible, but I noticed an area where 1Password might be able to excel because of it's embedded activation. If the password manager is activated on the window, it makes sense that it would only be able to suggest for the domain of the window. However, with 1Password X being activated in the input, it seems like it would be able to suggest passwords for the domain of an input inside an iframe.

The example here is an embedded login form for my school website. The window is on umich.instructure.com, but I want to fill an input inside a frame on weblogin.umich.edu.

In this screenshot, 1Password identifies the login form on weblogin.umich.edu and suggests the proper login:

In this screenshot, the login form is inside an iframe. While the domain the form is hosted on is still the same, 1Password uses the domain of the outer window to suggest. I don't have umich.instructure.com configured as a website for this login, so it is not presented.

Does this seem like a possible scenario to address?

In the meantime, I've added the outer domain to the list of websites for this login, so I guess this idea is pretty low priority as well.


1Password Version: Not Provided
Extension Version: Firefox 1.6.3
OS Version: Ubuntu 17.10
Sync Type: Not Provided

Comments

  • MitchMitch

    Team Member

    Hi @shreve,

    Thanks for the detailed post and suggestion. You make a perceptive point and it's one we've been aware of all along — 1Password X can make different, often better, decisions about filling because you're interacting directly with the page instead of the window.

    There is already some code in 1Password X to handle filling and saving when nested iframes are involved. I'll look into your specific case more closely to figure out if there's anything we can do to make it work the way you described. I think we can do better here, and you've given me motivation to find out how. :)

    -Mitch

Leave a Comment

BoldItalicStrikethroughOrdered listUnordered list
Emoji
Image
Align leftAlign centerAlign rightToggle HTML viewToggle full pageToggle lights
Drop image/file