Feature Request: Better support for custom uri schemas

cpmcgrath · May 2018

Let's take the Remote Desktop URI as an example: https://docs.microsoft.com/en-us/windows-server/remote/remote-desktop-services/clients/remote-desktop-uri

Android
The 1Password app refuses to open these links.

The Windows app

If I make the uri rdp://mypc the app sends it properly to my web browser which then properly opens the app - However, this uri does not conform to the schema.
If I make the uri rdp://full%20address=s:mypc the app sends it to the browser as https://rdp//full address=s:mypc

Ideally, it should be able to open these links without sending it to the browser first, but if it just sends it to the browser with the correct address it would be okay.

Finally, as shown above the RDP uri schema is stupidly verbose and ugly. It would be nice if we could make custom field types so that the field could just contain mypc, and the field type prefixed it with rdp://full%20address=s:

(Side note: Yes, I know Windows doesn't support this schema yet, but chances are it will in the near future, and in the meantime, I can write my own custom protocol handler to handle it and for compatibility reasons I'd want to follow the standard.)

1Password Version: 6.8.534
Extension Version: Not Provided
OS Version: Windows 10
Sync Type: Not Provided

AGAlumB · May 2018

@cpmcgrath: Ideally URL schemes are handled by the OS, but it's something we can consider. To my knowledge it hasn't come up before though, and we do need to focus on things that will help the greatest number of users. I think you hit the nail on the head: for compatibility (and interoperability, and security) reasons it's generally best to follow the platform lead. Is there precedence for this? There's a lot to be said for just passing on the full URL to the browser, but then 1Password would have to be handling all of this itself, and would not respect the system's default browser setting...which some people might like, but would confuse a lot of people too. It's an interesting idea though.

cpmcgrath · May 2018

I'm happy for 1Password to let the OS handle the Custom URIs, I went on a few tangents but the basic points are:

The Android app does not let the OS handle the URI.
In certain circumstances, the Windows app does not let the OS handle the URI and wraps it into a Http URL

If you guys were able to fix that, it would be awesome.

As always, thanks for your response!

AGAlumB · May 2018

Likewise, thanks for yours! You make some good points. We've got a lot on our plate on both Android and Windows right now, so I'm not sure this is something we'll get to in the near term, but we'll keep it in mind. I agree that it would be better for the Android app to do things differently in this regard, but we have a lot of work to do there first. There are some ideas we've been exploring around browser handling on the desktop especially, and perhaps we can make it more flexible in the future in a way that will help your use case as well. We shall see. :)

cpmcgrath · May 2018

Just checked this still happens in 1Password 7. I believe you use .NET so I quickly wrote the code that will do this for you:

using System.Diagnostics;
using System.Text.RegularExpressions;

public void GoToUrl(string url)
{
    var regex = new Regex(@"^\w+://");

    if (!regex.Match(url).Success)
    {
        url = "https://" + url;
    }

    Process.Start(url);
}

GoToUrl("rdp://full address=s:mypc");
GoToUrl("http://google.com");
GoToUrl("https://google.com");
GoToUrl("google.com");

MikeT · May 2018

Hi @cpmcgrath,

Thanks, I've passed it on to our developers to review. If you're looking for a job, we are looking for more C# developers to join our team, you can email your resume to us at support+windows@agilebits.com. :smile:

ref: OPW-2252

Feature Request: Better support for custom uri schemas

Comments